From fcc0835e931c6ed464bd57e0166399f5c7e6a40a Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Mon, 11 Jan 2021 11:26:51 -0800 Subject: [PATCH] refactoring --- pkg/driver/mounter.go | 4 ++-- pkg/driver/mounter_seaweedfs.go | 16 ++++++++-------- pkg/driver/nodeserver.go | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/pkg/driver/mounter.go b/pkg/driver/mounter.go index f18fa3c..9aaa84a 100644 --- a/pkg/driver/mounter.go +++ b/pkg/driver/mounter.go @@ -19,8 +19,8 @@ type Mounter interface { Mount(target string) error } -func newMounter(bucketName string, filer string) (Mounter, error) { - return newSeaweedFsMounter(bucketName, filer) +func newMounter(bucketName string, driver *SeaweedFsDriver) (Mounter, error) { + return newSeaweedFsMounter(bucketName, driver) } func fuseMount(path string, command string, args []string) error { diff --git a/pkg/driver/mounter_seaweedfs.go b/pkg/driver/mounter_seaweedfs.go index edd3c9d..848da85 100644 --- a/pkg/driver/mounter_seaweedfs.go +++ b/pkg/driver/mounter_seaweedfs.go @@ -8,23 +8,23 @@ import ( // Implements Mounter type seaweedFsMounter struct { - bucketName string - filerUrl string + bucketName string + driver *SeaweedFsDriver } const ( seaweedFsCmd = "weed" ) -func newSeaweedFsMounter(bucketName string, filer string) (Mounter, error) { +func newSeaweedFsMounter(bucketName string, driver *SeaweedFsDriver) (Mounter, error) { return &seaweedFsMounter{ - bucketName: bucketName, - filerUrl: filer, + bucketName: bucketName, + driver: driver, }, nil } func (seaweedFs *seaweedFsMounter) Mount(target string) error { - glog.V(0).Infof("mounting %s%s to %s", seaweedFs.filerUrl, seaweedFs.bucketName, target) + glog.V(0).Infof("mounting %s%s to %s", seaweedFs.driver.filer, seaweedFs.bucketName, target) args := []string{ "mount", @@ -32,12 +32,12 @@ func (seaweedFs *seaweedFsMounter) Mount(target string) error { "-umask=000", fmt.Sprintf("-dir=%s", target), fmt.Sprintf("-collection=%s", seaweedFs.bucketName), - fmt.Sprintf("-filer=%s", seaweedFs.filerUrl), + fmt.Sprintf("-filer=%s", seaweedFs.driver.filer), fmt.Sprintf("-filer.path=/buckets/%s", seaweedFs.bucketName), } err := fuseMount(target, seaweedFsCmd, args) if err != nil { - glog.Errorf("mount %s%s to %s: %s", seaweedFs.filerUrl, seaweedFs.bucketName, target, err) + glog.Errorf("mount %s%s to %s: %s", seaweedFs.driver.filer, seaweedFs.bucketName, target, err) } return err } diff --git a/pkg/driver/nodeserver.go b/pkg/driver/nodeserver.go index 82e1aed..0509f79 100644 --- a/pkg/driver/nodeserver.go +++ b/pkg/driver/nodeserver.go @@ -55,7 +55,7 @@ func (ns *NodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis mo = append(mo, "ro") } - mounter, err := newMounter(volumeID, ns.Driver.filer) + mounter, err := newMounter(volumeID, ns.Driver) if err != nil { return nil, err }